Strange months length (number of days)

Replies to This Discussion

Permalink Reply by Abraham Yezioro on November 17, 2015 at 3:26am

Indeed there is an issue.

-A.

Permalink Reply by Francesco De Luca on November 17, 2015 at 3:50am

Yes I think that the component considers the first month always as January, the second as February and so on and so forth.

Permalink Reply by Chris Mackey on November 17, 2015 at 1:22pm

This appears to be a big issue, indeed.  If Mostapha has not been able to look into it within a day, I will try my best to fix it.  The sunpath is in some great need to code-cleaning, though, and Mostapha would be able to fix it much more quickly than I.

-Chris

Permalink Reply by Mostapha Sadeghipour Roudsari on November 17, 2015 at 10:58pm

Yes! Francesco's instinct was right. It was a bug for partial analysis period. Just fixed it (https://github.com/mostaphaRoudsari/ladybug/commit/fc871a69f0893ef0...).

Permalink Reply by Chris Mackey on November 18, 2015 at 6:23am

Awesome! Thanks, Mostapha!

Permalink Reply by Francesco De Luca on November 18, 2015 at 5:58am

Hello all,

thank you very much. I will try this soon. 

And soon I'll post also another thing, not an issue but a suggestion for a modification

or the addition of a feature.